* Add user-owned IM channel connections
* Fix dev startup and channel connect popup
* Use async channel connect flow
* Harden dev service daemon startup
* Support local IM channel connections
* Align IM connections with local channels
* Fix safe user id digest algorithm
* Address Copilot IM channel feedback
* Address IM channel review comments
* Support all integrated IM channel connections
* Format additional channel connection tests
* Keep unavailable channel connect buttons clickable
* Fix IM channel provider icons
* Add runtime setup for enabled IM channels
* Guard global shortcut key handling
* Keep configured IM channels editable
* Avoid password autofill for channel secrets
* Make channel threads visible to connection owners
* Persist IM runtime config locally
* Allow disconnecting runtime IM channels
* Route no-auth channel sessions to local user
* Use default user for auth-disabled local mode
* Show IM channel source on threads
* Prefill IM channel runtime config
* Reflect IM channel runtime health
* Ignore Feishu message read events
* Ignore Feishu non-content message events
* Let setup wizard enable IM channels
* Fix frontend formatting after merge
* Stabilize backend tests without local config
* Isolate channel runtime config tests
* Address channel connection review comments
* Use sha256 user buckets with legacy migration
* Ensure runtime IM channels are ready after restart
* Persist disconnected IM channel state
* Address channel connection review comments
* Address channel connection review findings
Frontend connect flow:
- Open the runtime-config dialog only when a provider still needs
credentials; configured providers go straight to the connect flow, so
the binding-code/deep-link path is reachable from the UI again.
- After saving credentials, continue into the connect flow when a user
binding is still required (multi-user mode) instead of stopping at a
"Connected" toast.
- Extract shared provider-state helpers to core/channels/provider-state
and add unit + e2e coverage for the direct-connect and
configure-then-connect paths.
Provider status semantics:
- Report connection_status from the user's newest connection row;
with no binding it is not_connected, except in auth-disabled local
mode where a configured running channel is effectively connected.
Concurrency and event-loop correctness:
- Offload ChannelRuntimeConfigStore construction and writes, channel
service construction, and Slack connection replies to threads; add a
tests/blocking_io/ anchor for the runtime-config handlers.
- Consume binding codes with a conditional UPDATE so a code can only be
used once under concurrent workers; retry upsert_connection as an
update when a concurrent insert wins the unique constraint.
- Serialize ensure_channel_ready per channel so concurrent provider
polls cannot double-start a channel worker.
Config and migration hardening:
- Stop mutating the get_app_config()-cached Telegram provider config;
the runtime store now owns the UI-entered bot username.
- Register channel_connections in STARTUP_ONLY_FIELDS with the
standardized startup-only Field description.
- Match the legacy unsafe-id bucket by recomputing its exact SHA-1 name
so another user's same-prefix bucket can never be migrated.
- Remove the unused Telegram process_webhook_update path and document
src/core/channels in the frontend docs.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Address PR review comments on authz scoping and channel runtime
Security (review feedback from ShenAC-SAC):
- Scope internal-token callers to the connection owner carried in
X-DeerFlow-Owner-User-Id instead of bypassing owner checks outright,
in both require_permission(owner_check=True) and the stateless run
endpoints. Internal callers keep access to their own and
shared/legacy threads, and may claim a default-owned channel thread
for its real owner, but a leaked internal token no longer grants
cross-user thread access.
- Require admin privileges for POST/DELETE /api/channels/{provider}/
runtime-config: runtime credentials and channel workers are
instance-wide shared state (same model as the MCP config API).
Read-only provider listing stays available to all users.
Performance (review feedback from willem-bd):
- Skip the redundant thread channel-metadata PATCH after the first
successful backfill per thread.
- Reuse the per-connection Slack WebClient until its token changes
instead of constructing one per outbound message.
- Reconcile channel readiness for all providers concurrently in
GET /api/channels/providers.
Also resolve the code-quality unused-import flag in the blocking-io
anchor by pre-importing the channel service via importlib.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Fix prettier formatting in provider-state test
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Reconcile UI runtime channel config with config reload on restart
Main now reloads a channel's config.yaml entry on restart_channel()
(#3514, issue #3497). Adapt the user-owned connection flow to coexist:
- configure_channel() restarts with reload_config=False — the caller
just supplied the authoritative config (browser-entered credentials
that are never written to config.yaml), so a file reload must not
clobber it with the stale on-disk entry.
- _load_channel_config() re-applies the UI runtime-store overlay used
at startup, so an operator-triggered restart keeps browser-entered
credentials for channels without a config.yaml entry and does not
resurrect a channel disconnected from the UI.
- Offload the reload's disk IO (config.yaml + runtime store) with
asyncio.to_thread, matching the blocking-IO policy on this branch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
155 lines
5.0 KiB
Python
155 lines
5.0 KiB
Python
"""Slack connection tests for user-owned channel bindings."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from datetime import UTC, datetime, timedelta
|
|
from types import ModuleType
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
from app.channels.message_bus import MessageBus, OutboundMessage
|
|
|
|
|
|
async def _make_repo(tmp_path):
|
|
from deerflow.persistence.channel_connections import ChannelConnectionRepository, ChannelCredentialCipher
|
|
from deerflow.persistence.engine import get_session_factory, init_engine
|
|
|
|
await init_engine("sqlite", url=f"sqlite+aiosqlite:///{tmp_path / 'slack.db'}", sqlite_dir=str(tmp_path))
|
|
return ChannelConnectionRepository(
|
|
get_session_factory(),
|
|
cipher=ChannelCredentialCipher.from_key("slack-secret"),
|
|
)
|
|
|
|
|
|
def test_slack_connect_command_binds_socket_mode_identity(tmp_path):
|
|
import anyio
|
|
|
|
from app.channels.slack import SlackChannel
|
|
|
|
async def go():
|
|
repo = await _make_repo(tmp_path)
|
|
state = "slack-bind-code"
|
|
await repo.create_oauth_state(
|
|
owner_user_id="deerflow-user-1",
|
|
provider="slack",
|
|
state=state,
|
|
expires_at=datetime.now(UTC) + timedelta(minutes=5),
|
|
)
|
|
channel = SlackChannel(
|
|
bus=MessageBus(),
|
|
config={"bot_token": "xoxb-operator", "app_token": "xapp-operator", "connection_repo": repo},
|
|
)
|
|
channel._web_client = MagicMock()
|
|
|
|
handled = await channel._bind_connection_from_connect_code(
|
|
event={
|
|
"user": "U123",
|
|
"channel": "C123",
|
|
"ts": "1710000000.000100",
|
|
},
|
|
team_id="T123",
|
|
code=state,
|
|
)
|
|
|
|
connections = await repo.list_connections("deerflow-user-1")
|
|
assert handled is True
|
|
assert len(connections) == 1
|
|
assert connections[0]["provider"] == "slack"
|
|
assert connections[0]["external_account_id"] == "U123"
|
|
assert connections[0]["workspace_id"] == "T123"
|
|
assert connections[0]["metadata"]["channel_id"] == "C123"
|
|
channel._web_client.chat_postMessage.assert_called_once()
|
|
await repo.close()
|
|
|
|
anyio.run(go)
|
|
|
|
|
|
def test_slack_send_uses_connection_bot_token_when_connection_id_is_present():
|
|
import anyio
|
|
|
|
from app.channels.slack import SlackChannel
|
|
|
|
async def go():
|
|
repo = AsyncMock()
|
|
repo.get_credentials.return_value = {"access_token": "xoxb-connection-token"}
|
|
web_client = MagicMock()
|
|
web_client_factory = MagicMock(return_value=web_client)
|
|
channel = SlackChannel(
|
|
bus=MessageBus(),
|
|
config={
|
|
"connection_repo": repo,
|
|
"web_client_factory": web_client_factory,
|
|
},
|
|
)
|
|
|
|
msg = OutboundMessage(
|
|
channel_name="slack",
|
|
chat_id="C123",
|
|
thread_id="thread-1",
|
|
text="hello",
|
|
connection_id="connection-1",
|
|
)
|
|
await channel.send(msg)
|
|
|
|
repo.get_credentials.assert_awaited_once_with("connection-1")
|
|
web_client_factory.assert_called_once_with(token="xoxb-connection-token")
|
|
web_client.chat_postMessage.assert_called_once()
|
|
|
|
anyio.run(go)
|
|
|
|
|
|
def test_slack_http_events_mode_initializes_operator_web_client(monkeypatch):
|
|
import anyio
|
|
|
|
from app.channels.slack import SlackChannel
|
|
|
|
class FakeWebClient:
|
|
def __init__(self, token: str) -> None:
|
|
self.token = token
|
|
self.messages: list[dict] = []
|
|
|
|
def auth_test(self):
|
|
return {"user_id": "B-http"}
|
|
|
|
def chat_postMessage(self, **kwargs):
|
|
self.messages.append(kwargs)
|
|
|
|
slack_sdk = ModuleType("slack_sdk")
|
|
slack_sdk.WebClient = FakeWebClient
|
|
socket_mode = ModuleType("slack_sdk.socket_mode")
|
|
socket_mode.SocketModeClient = object
|
|
response = ModuleType("slack_sdk.socket_mode.response")
|
|
response.SocketModeResponse = object
|
|
monkeypatch.setitem(sys.modules, "slack_sdk", slack_sdk)
|
|
monkeypatch.setitem(sys.modules, "slack_sdk.socket_mode", socket_mode)
|
|
monkeypatch.setitem(sys.modules, "slack_sdk.socket_mode.response", response)
|
|
|
|
async def go():
|
|
channel = SlackChannel(
|
|
bus=MessageBus(),
|
|
config={
|
|
"bot_token": "xoxb-operator",
|
|
"event_delivery": "http",
|
|
"connection_repo": MagicMock(),
|
|
},
|
|
)
|
|
|
|
await channel.start()
|
|
assert channel._running is True
|
|
assert channel._web_client is not None
|
|
assert channel._web_client.token == "xoxb-operator"
|
|
assert channel._bot_user_id == "B-http"
|
|
|
|
await channel._post_connection_reply("C123", "Slack connected to DeerFlow.", "1710000000.000100")
|
|
|
|
assert channel._web_client.messages == [
|
|
{
|
|
"channel": "C123",
|
|
"text": "Slack connected to DeerFlow.",
|
|
"thread_ts": "1710000000.000100",
|
|
}
|
|
]
|
|
await channel.stop()
|
|
|
|
anyio.run(go)
|