395 lines
14 KiB
Python
395 lines
14 KiB
Python
"""Tests for app.gateway.services — run lifecycle service layer."""
|
||
|
||
from __future__ import annotations
|
||
|
||
import json
|
||
from unittest.mock import AsyncMock, patch
|
||
|
||
from langchain_core.messages import HumanMessage
|
||
|
||
|
||
def test_format_sse_basic():
|
||
from app.gateway.services import format_sse
|
||
|
||
frame = format_sse("metadata", {"run_id": "abc"})
|
||
assert frame.startswith("event: metadata\n")
|
||
assert "data: " in frame
|
||
parsed = json.loads(frame.split("data: ")[1].split("\n")[0])
|
||
assert parsed["run_id"] == "abc"
|
||
|
||
|
||
def test_format_sse_with_event_id():
|
||
from app.gateway.services import format_sse
|
||
|
||
frame = format_sse("metadata", {"run_id": "abc"}, event_id="123-0")
|
||
assert "id: 123-0" in frame
|
||
|
||
|
||
def test_format_sse_end_event_null():
|
||
from app.gateway.services import format_sse
|
||
|
||
frame = format_sse("end", None)
|
||
assert "data: null" in frame
|
||
|
||
|
||
def test_format_sse_no_event_id():
|
||
from app.gateway.services import format_sse
|
||
|
||
frame = format_sse("values", {"x": 1})
|
||
assert "id:" not in frame
|
||
|
||
|
||
def test_normalize_stream_modes_none():
|
||
from app.gateway.services import normalize_stream_modes
|
||
|
||
assert normalize_stream_modes(None) == ["values"]
|
||
|
||
|
||
def test_normalize_stream_modes_string():
|
||
from app.gateway.services import normalize_stream_modes
|
||
|
||
assert normalize_stream_modes("messages-tuple") == ["messages-tuple"]
|
||
|
||
|
||
def test_normalize_stream_modes_list():
|
||
from app.gateway.services import normalize_stream_modes
|
||
|
||
assert normalize_stream_modes(["values", "messages-tuple"]) == ["values", "messages-tuple"]
|
||
|
||
|
||
def test_normalize_stream_modes_empty_list():
|
||
from app.gateway.services import normalize_stream_modes
|
||
|
||
assert normalize_stream_modes([]) == ["values"]
|
||
|
||
|
||
def test_normalize_input_none():
|
||
from app.gateway.services import normalize_input
|
||
|
||
assert normalize_input(None) == {}
|
||
|
||
|
||
def test_normalize_input_with_messages():
|
||
from app.gateway.services import normalize_input
|
||
|
||
result = normalize_input({"messages": [{"role": "user", "content": "hi"}]})
|
||
assert len(result["messages"]) == 1
|
||
assert result["messages"][0].content == "hi"
|
||
|
||
|
||
def test_normalize_input_passthrough():
|
||
from app.gateway.services import normalize_input
|
||
|
||
result = normalize_input({"custom_key": "value"})
|
||
assert result == {"custom_key": "value"}
|
||
|
||
|
||
def test_extract_last_human_text_from_human_message():
|
||
from app.gateway.services import _extract_last_human_text
|
||
|
||
graph_input = {
|
||
"messages": [
|
||
HumanMessage(content="第一条"),
|
||
HumanMessage(content=[{"type": "text", "text": "我要做一个产品发布会PPT"}]),
|
||
]
|
||
}
|
||
assert _extract_last_human_text(graph_input) == "我要做一个产品发布会PPT"
|
||
|
||
|
||
def test_is_ppt_request():
|
||
from app.gateway.services import _is_ppt_request
|
||
|
||
assert _is_ppt_request("帮我做个PPT")
|
||
assert _is_ppt_request("Please generate slides for roadmap")
|
||
assert not _is_ppt_request("帮我写一段 SQL")
|
||
|
||
|
||
def test_heuristic_has_enough_ppt_info():
|
||
from app.gateway.services import _heuristic_has_enough_ppt_info
|
||
|
||
assert not _heuristic_has_enough_ppt_info("做个ppt")
|
||
assert _heuristic_has_enough_ppt_info("做一个关于Q2复盘的PPT，面向管理层，10页，简洁风格")
|
||
|
||
|
||
def test_overwrite_last_human_message():
|
||
from app.gateway.services import _overwrite_last_human_message
|
||
|
||
graph_input = {"messages": [HumanMessage(content="请生成PPT")]}
|
||
_overwrite_last_human_message(graph_input, "用户想生成ppt，但是没有输入足够多的信息，所以先向用户询问更多信息")
|
||
assert graph_input["messages"][-1].content == "用户想生成ppt，但是没有输入足够多的信息，所以先向用户询问更多信息"
|
||
|
||
|
||
def test_maybe_apply_ppt_precheck_rewrites_when_insufficient():
|
||
from app.gateway.services import _maybe_apply_ppt_precheck
|
||
|
||
graph_input = {"messages": [HumanMessage(content="帮我做个PPT")]}
|
||
with patch(
|
||
"app.gateway.services._deepseek_ppt_info_check",
|
||
new=AsyncMock(return_value=False),
|
||
):
|
||
import asyncio
|
||
|
||
asyncio.run(_maybe_apply_ppt_precheck(graph_input))
|
||
assert graph_input["messages"][-1].content == "用户想生成ppt，但是没有输入足够多的信息，所以先向用户询问更多信息"
|
||
|
||
|
||
def test_build_run_config_basic():
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config("thread-1", None, None)
|
||
assert config["configurable"]["thread_id"] == "thread-1"
|
||
assert config["recursion_limit"] == 100
|
||
|
||
|
||
def test_build_run_config_with_overrides():
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{"configurable": {"model_name": "gpt-4"}, "tags": ["test"]},
|
||
{"user": "alice"},
|
||
)
|
||
assert config["configurable"]["model_name"] == "gpt-4"
|
||
assert config["tags"] == ["test"]
|
||
assert config["metadata"]["user"] == "alice"
|
||
|
||
|
||
# ---------------------------------------------------------------------------
|
||
# Regression tests for issue #1644:
|
||
# assistant_id not mapped to agent_name → custom agent SOUL.md never loaded
|
||
# ---------------------------------------------------------------------------
|
||
|
||
|
||
def test_build_run_config_custom_agent_injects_agent_name():
|
||
"""Custom assistant_id must be forwarded as configurable['agent_name']."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config("thread-1", None, None, assistant_id="finalis")
|
||
assert config["configurable"]["agent_name"] == "finalis"
|
||
|
||
|
||
def test_build_run_config_lead_agent_no_agent_name():
|
||
"""'lead_agent' assistant_id must NOT inject configurable['agent_name']."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config("thread-1", None, None, assistant_id="lead_agent")
|
||
assert "agent_name" not in config["configurable"]
|
||
|
||
|
||
def test_build_run_config_none_assistant_id_no_agent_name():
|
||
"""None assistant_id must NOT inject configurable['agent_name']."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config("thread-1", None, None, assistant_id=None)
|
||
assert "agent_name" not in config["configurable"]
|
||
|
||
|
||
def test_build_run_config_explicit_agent_name_not_overwritten():
|
||
"""An explicit configurable['agent_name'] in the request must take precedence."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{"configurable": {"agent_name": "explicit-agent"}},
|
||
None,
|
||
assistant_id="other-agent",
|
||
)
|
||
assert config["configurable"]["agent_name"] == "explicit-agent"
|
||
|
||
|
||
def test_resolve_agent_factory_returns_make_lead_agent():
|
||
"""resolve_agent_factory always returns make_lead_agent regardless of assistant_id."""
|
||
from app.gateway.services import resolve_agent_factory
|
||
from deerflow.agents.lead_agent.agent import make_lead_agent
|
||
|
||
assert resolve_agent_factory(None) is make_lead_agent
|
||
assert resolve_agent_factory("lead_agent") is make_lead_agent
|
||
assert resolve_agent_factory("finalis") is make_lead_agent
|
||
assert resolve_agent_factory("custom-agent-123") is make_lead_agent
|
||
|
||
|
||
# ---------------------------------------------------------------------------
|
||
|
||
# ---------------------------------------------------------------------------
|
||
# Regression tests for issue #1699:
|
||
# context field in langgraph-compat requests not merged into configurable
|
||
# ---------------------------------------------------------------------------
|
||
|
||
|
||
def test_run_create_request_accepts_context():
|
||
"""RunCreateRequest must accept the ``context`` field without dropping it."""
|
||
from app.gateway.routers.thread_runs import RunCreateRequest
|
||
|
||
body = RunCreateRequest(
|
||
input={"messages": [{"role": "user", "content": "hi"}]},
|
||
context={
|
||
"model_name": "deepseek-v3",
|
||
"thinking_enabled": True,
|
||
"is_plan_mode": True,
|
||
"subagent_enabled": True,
|
||
"thread_id": "some-thread-id",
|
||
},
|
||
)
|
||
assert body.context is not None
|
||
assert body.context["model_name"] == "deepseek-v3"
|
||
assert body.context["is_plan_mode"] is True
|
||
assert body.context["subagent_enabled"] is True
|
||
|
||
|
||
def test_run_create_request_context_defaults_to_none():
|
||
"""RunCreateRequest without context should default to None (backward compat)."""
|
||
from app.gateway.routers.thread_runs import RunCreateRequest
|
||
|
||
body = RunCreateRequest(input=None)
|
||
assert body.context is None
|
||
|
||
|
||
def test_context_merges_into_configurable():
|
||
"""Context values must be merged into config['configurable'] by start_run.
|
||
|
||
Since start_run is async and requires many dependencies, we test the
|
||
merging logic directly by simulating what start_run does.
|
||
"""
|
||
from app.gateway.services import build_run_config
|
||
|
||
# Simulate the context merging logic from start_run
|
||
config = build_run_config("thread-1", None, None)
|
||
|
||
context = {
|
||
"model_name": "deepseek-v3",
|
||
"mode": "ultra",
|
||
"reasoning_effort": "high",
|
||
"thinking_enabled": True,
|
||
"is_plan_mode": True,
|
||
"subagent_enabled": True,
|
||
"max_concurrent_subagents": 5,
|
||
"thread_id": "should-be-ignored",
|
||
}
|
||
|
||
_CONTEXT_CONFIGURABLE_KEYS = {
|
||
"model_name",
|
||
"mode",
|
||
"thinking_enabled",
|
||
"reasoning_effort",
|
||
"is_plan_mode",
|
||
"subagent_enabled",
|
||
"max_concurrent_subagents",
|
||
}
|
||
configurable = config.setdefault("configurable", {})
|
||
for key in _CONTEXT_CONFIGURABLE_KEYS:
|
||
if key in context:
|
||
configurable.setdefault(key, context[key])
|
||
|
||
assert config["configurable"]["model_name"] == "deepseek-v3"
|
||
assert config["configurable"]["thinking_enabled"] is True
|
||
assert config["configurable"]["is_plan_mode"] is True
|
||
assert config["configurable"]["subagent_enabled"] is True
|
||
assert config["configurable"]["max_concurrent_subagents"] == 5
|
||
assert config["configurable"]["reasoning_effort"] == "high"
|
||
assert config["configurable"]["mode"] == "ultra"
|
||
# thread_id from context should NOT override the one from build_run_config
|
||
assert config["configurable"]["thread_id"] == "thread-1"
|
||
# Non-allowlisted keys should not appear
|
||
assert "thread_id" not in {k for k in context if k in _CONTEXT_CONFIGURABLE_KEYS}
|
||
|
||
|
||
def test_context_does_not_override_existing_configurable():
|
||
"""Values already in config.configurable must NOT be overridden by context."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{"configurable": {"model_name": "gpt-4", "is_plan_mode": False}},
|
||
None,
|
||
)
|
||
|
||
context = {
|
||
"model_name": "deepseek-v3",
|
||
"is_plan_mode": True,
|
||
"subagent_enabled": True,
|
||
}
|
||
|
||
_CONTEXT_CONFIGURABLE_KEYS = {
|
||
"model_name",
|
||
"mode",
|
||
"thinking_enabled",
|
||
"reasoning_effort",
|
||
"is_plan_mode",
|
||
"subagent_enabled",
|
||
"max_concurrent_subagents",
|
||
}
|
||
configurable = config.setdefault("configurable", {})
|
||
for key in _CONTEXT_CONFIGURABLE_KEYS:
|
||
if key in context:
|
||
configurable.setdefault(key, context[key])
|
||
|
||
# Existing values must NOT be overridden
|
||
assert config["configurable"]["model_name"] == "gpt-4"
|
||
assert config["configurable"]["is_plan_mode"] is False
|
||
# New values should be added
|
||
assert config["configurable"]["subagent_enabled"] is True
|
||
|
||
|
||
# ---------------------------------------------------------------------------
|
||
# build_run_config — context / configurable precedence (LangGraph >= 0.6.0)
|
||
# ---------------------------------------------------------------------------
|
||
|
||
|
||
def test_build_run_config_with_context():
|
||
"""When caller sends 'context', prefer it over 'configurable'."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{"context": {"user_id": "u-42", "thread_id": "thread-1"}},
|
||
None,
|
||
)
|
||
assert "context" in config
|
||
assert config["context"]["user_id"] == "u-42"
|
||
assert "configurable" not in config
|
||
assert config["recursion_limit"] == 100
|
||
|
||
|
||
def test_build_run_config_context_plus_configurable_warns(caplog):
|
||
"""When caller sends both 'context' and 'configurable', prefer 'context' and log a warning."""
|
||
import logging
|
||
|
||
from app.gateway.services import build_run_config
|
||
|
||
with caplog.at_level(logging.WARNING, logger="app.gateway.services"):
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{
|
||
"context": {"user_id": "u-42"},
|
||
"configurable": {"model_name": "gpt-4"},
|
||
},
|
||
None,
|
||
)
|
||
assert "context" in config
|
||
assert config["context"]["user_id"] == "u-42"
|
||
assert "configurable" not in config
|
||
assert any("both 'context' and 'configurable'" in r.message for r in caplog.records)
|
||
|
||
|
||
def test_build_run_config_context_passthrough_other_keys():
|
||
"""Non-conflicting keys from request_config are still passed through when context is used."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config(
|
||
"thread-1",
|
||
{"context": {"thread_id": "thread-1"}, "tags": ["prod"]},
|
||
None,
|
||
)
|
||
assert config["context"]["thread_id"] == "thread-1"
|
||
assert "configurable" not in config
|
||
assert config["tags"] == ["prod"]
|
||
|
||
|
||
def test_build_run_config_no_request_config():
|
||
"""When request_config is None, fall back to basic configurable with thread_id."""
|
||
from app.gateway.services import build_run_config
|
||
|
||
config = build_run_config("thread-abc", None, None)
|
||
assert config["configurable"] == {"thread_id": "thread-abc"}
|
||
assert "context" not in config
|