skills
/
deerflow2
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(tools): move sandbox.tools import in view_image_tool to break circular import (#1674) 

view_image_tool.py had a top-level import of deerflow.sandbox.tools, which
created a circular dependency chain:

  sandbox.tools
    -> deerflow.agents.thread_state (triggers agents/__init__.py)
      -> agents/factory.py
        -> tools/builtins/__init__.py
          -> view_image_tool.py
            -> deerflow.sandbox.tools  <-- circular!

This caused ImportError when any test directly imported sandbox.tools,
making test_sandbox_tools_security.py fail to collect since #1522.

Fix: move the sandbox.tools import inside the view_image_tool function body.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
SHIYAO ZHANG 2026-03-31 22:05:23 +08:00 committed by GitHub
parent 09a9209724
commit c2f7be37b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
backend/packages/harness/deerflow/tools/builtins/view_image_tool.py
View File

@ -9,7 +9,6 @@ from langgraph.types import Command
from langgraph.typing import ContextT from langgraph.typing import ContextT
from deerflow.agents.thread_state import ThreadState from deerflow.agents.thread_state import ThreadState
from deerflow.sandbox.tools import get_thread_data, replace_virtual_path
@tool("view_image", parse_docstring=True) @tool("view_image", parse_docstring=True)
@ -32,6 +31,8 @@ def view_image_tool(
Args: Args:
image_path: Absolute path to the image file. Common formats supported: jpg, jpeg, png, webp. image_path: Absolute path to the image file. Common formats supported: jpg, jpeg, png, webp.
""" """
from deerflow.sandbox.tools import get_thread_data, replace_virtual_path
# Replace virtual path with actual path # Replace virtual path with actual path
# /mnt/user-data/* paths are mapped to thread-specific directories # /mnt/user-data/* paths are mapped to thread-specific directories
thread_data = get_thread_data(runtime) thread_data = get_thread_data(runtime)